Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Association" loader loads unnecessary records on AR 5.2.3+ #37

Closed
Bajena opened this issue Dec 27, 2019 · 0 comments · Fixed by #36
Closed

"Association" loader loads unnecessary records on AR 5.2.3+ #37

Bajena opened this issue Dec 27, 2019 · 0 comments · Fixed by #36
Assignees
@Bajena

Comments

@Bajena
Copy link
Owner

Bajena commented Dec 27, 2019

Implementation of ActiveRecord's association preloader has changed slightly causing unnecessary loading of associations.

Let's filter out the records with preloaded associations.

AR change: rails/rails@0a5b41c#diff-8bdf4d71fc80d5866e82a8024bb148d2R187
@Bajena Bajena self-assigned this Dec 27, 2019
Bajena added a commit that referenced this issue Dec 27, 2019
@Bajena
Filter out preloaded records in Association preloader
128b4b2 
closes #37
@Bajena Bajena mentioned this issue Dec 27, 2019
Merged
Bajena added a commit that referenced this issue Dec 27, 2019
@Bajena
Filter out preloaded records in Association preloader (#36)
afad2d5 
* Install bundler in CI

* Move 'gem install' to another section

* Remove bad option

* Remove another invalid option

* Remove bundler from gemspec

* Update ruby version

* Update sqlite

* Check specs

* Release sqlite version requirement

* Filter out preloaded records in `Association` preloader

closes #37

* Fix CC issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bajena Bajena

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter out preloaded records in Association preloader Bajena/ams_lazy_relationships
1 participant
@Bajena