Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type hint using pymongo client session instead of motor client session #1022

Merged
merged 4 commits into from
Oct 3, 2024
Merged

fix type hint using pymongo client session instead of motor client session #1022

merged 4 commits into from
Oct 3, 2024
+145 −147

Conversation

CAPITAINMARVEL
Copy link
Contributor

this pull request fix the type hint of session

@adeelsohailahmed adeelsohailahmed requested a review from a team September 11, 2024 23:24
Riverfount
Riverfount previously approved these changes Sep 18, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

07pepa
07pepa previously approved these changes Sep 24, 2024
View reviewed changes
Riverfount
Riverfount approved these changes Sep 26, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CAPITAINMARVEL CAPITAINMARVEL requested a review from a team September 30, 2024 08:56
Riverfount
Riverfount approved these changes Sep 30, 2024
View reviewed changes
Copy link

@Riverfount Riverfount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok!

@CAPITAINMARVEL CAPITAINMARVEL changed the title fix beanie type hint using pymongo client session instead of motor client session fix type hint using pymongo client session instead of motor client session Oct 1, 2024
@CAPITAINMARVEL CAPITAINMARVEL enabled auto-merge (squash) October 1, 2024 18:37
staticxterm
staticxterm approved these changes Oct 3, 2024
View reviewed changes
Copy link

@staticxterm staticxterm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only potential problem may be when syncing Bunnet with latest Beanie, but I'm not sure how that is done exactly. From the perspective of Beanie alone, this is not a breaking change. Thank you.

@CAPITAINMARVEL CAPITAINMARVEL merged commit b438edc into BeanieODM:main Oct 3, 2024
19 checks passed
@CAPITAINMARVEL CAPITAINMARVEL deleted the fix_session branch October 3, 2024 20:23
@CAPITAINMARVEL CAPITAINMARVEL mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticxterm staticxterm staticxterm approved these changes

@Riverfount Riverfount Riverfount approved these changes

@LawMixer LawMixer LawMixer approved these changes

@07pepa 07pepa Awaiting requested review from 07pepa

@adeelsohailahmed adeelsohailahmed Awaiting requested review from adeelsohailahmed

@ayusshsoarav ayusshsoarav Awaiting requested review from ayusshsoarav

@roman-right roman-right Awaiting requested review from roman-right

@timok19 timok19 Awaiting requested review from timok19

@arunkumarp93 arunkumarp93 Awaiting requested review from arunkumarp93

@ritiksoni00 ritiksoni00 Awaiting requested review from ritiksoni00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CAPITAINMARVEL @staticxterm @07pepa @Riverfount @LawMixer