Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect the dbt exit codes #37

Merged
merged 2 commits into from
Oct 12, 2024
Merged

Respect the dbt exit codes #37

merged 2 commits into from
Oct 12, 2024

Conversation

Bilbottom
Copy link
Owner

@Bilbottom Bilbottom commented Oct 11, 2024

Note

This is an adjusted version of #34, originally raised by @alexmaras.

dbt commands will return exit codes 0, 1, or 2 depending on the run result, but these were being masked by this shim (see #36).

This PR updates the shim to respect the dbt exit codes following the dbt docs:

This comment was marked as resolved.

sourcery-ai[bot]

This comment was marked as resolved.

@alexmaras
Copy link

Thanks for this - this looks great.

@Bilbottom Bilbottom merged commit edf43fa into main Oct 12, 2024
4 checks passed
@Bilbottom Bilbottom deleted the use-dbt-exit-codes branch October 12, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants