Error when translating gaps #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 91.20% 90.88% -0.33%
==========================================
Files 31 31
Lines 2400 2403 +3
==========================================
- Hits 2189 2184 -5
- Misses 211 219 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
DNA_Gap cannot be meaningfully translated, as it does not correspond to any nucleotides, not even an unknown one. In fact, it's dubious that it's even a nucleotide at all. This PR makes `translate(!)` error when run on sequences with gaps, whereas before this PR this was undefined behaviour (out-of-bounds access). Alternative solutions could be to silently skip gaps, which is biologically meaningful, but might lead to strange errors, or to insert AA_Gap, which can only be done if the gaps come in groups of three corresponding to a whole gap codon. In the future we could change behaviour to skip gaps. See issue 277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNA_Gap cannot be meaningfully translated, as it does not correspond to any nucleotides, not even an unknown one. In fact, it's dubious that it's even a nucleotide at all.
This PR makes
translate(!)error when run on sequences with gaps, whereas before this PR this was undefined behaviour (out-of-bounds access). Alternative solutions could be to silently skip gaps, which is biologically meaningful, but might lead to strange errors, or to insert AA_Gap, which can only be done if the gaps come in groups of three corresponding to a whole gap codon.In the future we could change behaviour to skip gaps.
Closes #277