Remove dependency on StableRNGs #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove StableRNGs from dependencies. Methods for LongSequence generation now default to using Random.DEFAULT_RNG. StableRNGs is kept as a test dependency to test reproducibility. See issue BioJulia#187.
Codecov Report
@@ Coverage Diff @@
## v3 #188 +/- ##
==========================================
+ Coverage 82.27% 82.88% +0.61%
==========================================
Files 31 31
Lines 2183 2401 +218
==========================================
+ Hits 1796 1990 +194
- Misses 387 411 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
TransGirlCodes
approved these changes
Oct 5, 2021
It doesn't look it StableRNG is used for the tests? Here is the default global rng used: BioSequences.jl/test/runtests.jl Line 38 in 0ba3d4b and here: BioSequences.jl/test/runtests.jl Line 60 in 0ba3d4b etc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove StableRNGs from dependencies.
Methods for LongSequence generation now default to using Random.DEFAULT_RNG.
StableRNGs is kept as a test dependency to test reproducibility.
See issue #187.