Rename stringbyte and avoid pirating BioSymbols #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename the un-released method `stringbyte(::Alphabet, ::UInt8)` to `ascii_encode` * Remove the un-released method `stringbyte(::BioSymbol)` to BioSymbols * Bump required BioSymbols ver to 5.1.0 to include new code in BioSymbols
Codecov Report
@@ Coverage Diff @@
## v3 #200 +/- ##
==========================================
+ Coverage 82.86% 82.89% +0.02%
==========================================
Files 31 31
Lines 2399 2397 -2
==========================================
- Hits 1988 1987 -1
+ Misses 411 410 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Merging this - the failed doc build was due to a pkg server issue, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #198, companion PR to BioJulia/BioSymbols.jl#48. See the PR to BioSymbols.
This change is not breaking. The changed function was undocumented and unexported.