WIP: Test bonanza for v3 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v3 #203 +/- ##
==========================================
+ Coverage 82.86% 88.44% +5.58%
==========================================
Files 31 31
Lines 2399 2372 -27
==========================================
+ Hits 1988 2098 +110
+ Misses 411 274 -137
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Since I consider this PR to be low-risk and unsurprising, I'm just merging right away, You're all welcome to review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve test coverage for v3
Resolves #139 . During the testing, it is possible some functions may be changed if they are discovered to be broken. This PR will contain an exhaustive list of all non-test changes, that is, changes in the
srcdirectory,Completion
Current changes / bugfixes
join!is now exported as it should have beenjoin!(::BioSequence, ::Vector)which caused it to fail_copyto!forBioSequencetoBase.copyto!. I don't know why it was an internal method before, honestly.unsafe_setindex!, which has been kept until now for backwards compatibilityis_canonicalincanonical(::BioSequence)Base.cmpforBitIndexextract_encoded_element(::BitIndex, ::NTuple)andbitmask(::Type, ::Val)LongSequence(it) = LongSequence{eltype(it)}(it)(was also wrong)LongSequence{A}(::Union{AbstractString,AbstractVector{UInt8}}, ::Integer, ::Integer)to take a range instead of two integers for consistency with other constructorsbitindex(::LongSubSeq, ::Integer)encoded_setindex!(::SeqOrView, ::Unsigned, ::Integer)symbols_per_data_element(::LongSubSeq)AbstractUnitRangeoverUnitRangewith identical behaviour