Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use codeunits over unsafe_wrap #239

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Conversation

jakobnissen
Copy link
Member

Small internal change that avoids the use of pointers and unsafe_wrap.
For some reason I see a 1% performance drop. The code SHOULD perform identical.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #239 (34e14a2) into master (bf4aac5) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   89.25%   89.29%   +0.03%     
==========================================
  Files          31       31              
  Lines        2430     2429       -1     
==========================================
  Hits         2169     2169              
+ Misses        261      260       -1     
Flag Coverage Δ
unittests 89.29% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/longsequences/constructors.jl 100.00% <100.00%> (ø)
src/bit-manipulation/bitpar-compiler.jl 70.83% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf4aac5...34e14a2. Read the comment docs.

@jakobnissen jakobnissen added the merge me Already reviewed, merge if checks pass label Jun 16, 2022
@jakobnissen jakobnissen merged commit 625ab2f into BioJulia:master Jun 16, 2022
@jakobnissen jakobnissen removed the merge me Already reviewed, merge if checks pass label Jun 16, 2022
@jakobnissen jakobnissen deleted the nowrap branch June 16, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant