Fix bug in zero_offset! called when materializing seqview #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When materializing a seqview, a slice of the underlying buffer is copied directly, for efficiency. Since the bytes may be placed in the buffer with a nonzero offset, the optimised zero_offset! is called. However, a bug in zero_offset! meant that it did not behave correctly when the offset was already zero.
Codecov ReportBase: 88.53% // Head: 88.54% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
=======================================
Coverage 88.53% 88.54%
=======================================
Files 31 31
Lines 2329 2330 +1
=======================================
+ Hits 2062 2063 +1
Misses 267 267
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When materializing a seqview, a slice of the underlying buffer is copied directly, for efficiency. Since the bytes may be placed in the buffer with a nonzero offset, the optimised zero_offset! is called. However, a bug in zero_offset! meant that it did not behave correctly when the offset was already zero.
Fix #260