A few fixes for tests #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out Julia is allowed to change the types of exceptions (#50633), which I'm pretty miffed about. Work around this to prevent tests from failing in Julia 1.11 due to Julia PR #49322.
* Remove the erroneous method Base.:*() with empty Varargs, and make sure that there is at least one `BioSequence`. * Fixup inner constructor for the test type `SimpleSequence`
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 91.21% 91.26% +0.04%
==========================================
Files 31 31
Lines 2403 2403
==========================================
+ Hits 2192 2193 +1
+ Misses 211 210 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.