forked from valkey-io/valkey-glide
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync and async clients both to tests. #12
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
13 changes: 13 additions & 0 deletions
13
java/jabushka/benchmarks/src/main/java/javabushka/client/AsyncClient.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package javabushka.client; | ||
|
||
import java.util.concurrent.Future; | ||
|
||
public interface AsyncClient extends Client { | ||
Future<?> asyncSet(String key, String value); | ||
|
||
Future<String> asyncGet(String key); | ||
|
||
<T> T waitForResult(Future<T> future); | ||
|
||
<T> T waitForResult(Future<T> future, long timeout); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
java/jabushka/benchmarks/src/main/java/javabushka/client/Client.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package javabushka.client; | ||
|
||
import javabushka.client.utils.ConnectionSettings; | ||
|
||
public interface Client { | ||
void connectToRedis(); | ||
|
||
void connectToRedis(ConnectionSettings connectionSettings); | ||
|
||
default void closeConnection() {} | ||
|
||
String getName(); | ||
} |
7 changes: 7 additions & 0 deletions
7
java/jabushka/benchmarks/src/main/java/javabushka/client/SyncClient.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package javabushka.client; | ||
|
||
public interface SyncClient extends Client { | ||
void set(String key, String value); | ||
|
||
String get(String key); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 39 additions & 0 deletions
39
java/jabushka/benchmarks/src/main/java/javabushka/client/jedis/JedisPseudoAsyncClient.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
package javabushka.client.jedis; | ||
|
||
import java.util.concurrent.CompletableFuture; | ||
import java.util.concurrent.Future; | ||
import java.util.concurrent.TimeUnit; | ||
import javabushka.client.AsyncClient; | ||
|
||
// Jedis doesn't provide async API | ||
// https:/redis/jedis/issues/241 | ||
public class JedisPseudoAsyncClient extends JedisClient implements AsyncClient { | ||
@Override | ||
public Future<?> asyncSet(String key, String value) { | ||
return CompletableFuture.runAsync(() -> super.set(key, value)); | ||
} | ||
|
||
@Override | ||
public Future<String> asyncGet(String key) { | ||
return CompletableFuture.supplyAsync(() -> super.get(key)); | ||
} | ||
|
||
@Override | ||
public <T> T waitForResult(Future<T> future) { | ||
return waitForResult(future, 1000); | ||
} | ||
|
||
@Override | ||
public <T> T waitForResult(Future<T> future, long timeout) { | ||
try { | ||
return future.get(timeout, TimeUnit.MILLISECONDS); | ||
} catch (Exception ignored) { | ||
return null; | ||
} | ||
} | ||
|
||
@Override | ||
public String getName() { | ||
return "Jedis pseudo-async"; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't affect performance results for small runs, right? Still, we should consider customizing this as it can have affect on large concurrent results (with lots of threads 'waiting').
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this into a constant. Maybe consider adding a command-line option to configure this or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, fixed in bffba11