Clean up all warnings in Java client test #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Carbonetto <[email protected]>
|
spotless hates you |
Signed-off-by: Andrew Carbonetto <[email protected]>
Yury-Fridlyand
approved these changes
Mar 27, 2024
| when(commandManager.<Void>submitNewCommand(eq(SetString), eq(new String[] {key, value}), any())) | ||
| CompletableFuture<String> testResponse = new CompletableFuture<>(); | ||
| testResponse.complete(null); | ||
| when(commandManager.<String>submitNewCommand( |
There was a problem hiding this comment.
our tests do almost nothing if they pass with such mistake
There was a problem hiding this comment.
Haha. I noticed. It doesn't care about the typing. Really, we should be failing with a warning... otherwise these tests are just checking that the right argument/requestType is being passed to protobuf.
jonathanl-bq
approved these changes
Mar 29, 2024
acarbonetto
merged commit f0b400e
into
java/integ_acarbo_clean_test_warnings
11 checks passed
acarbonetto
added a commit
that referenced
this pull request
Apr 4, 2024
* Clean up all warnings in Java client test Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up all warnings in the Java/Client test folder.