Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase allowed section type to 19 #462

Merged
merged 1 commit into from
Jun 23, 2023
Merged

increase allowed section type to 19 #462

merged 1 commit into from
Jun 23, 2023

Conversation

mgeplf
Copy link
Contributor

@mgeplf mgeplf commented Jun 22, 2023

@mgeplf
increase allowed section type to 19
4a22167 
* #432
* #456 (type 18 seen in the wild)
eleftherioszisis
eleftherioszisis approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@eleftherioszisis eleftherioszisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 19 arbitrary or is it based on a spec?

@mgeplf
Copy link
Contributor Author

mgeplf commented Jun 23, 2023

arbitrary; enough to be above 18 :)

@mgeplf mgeplf merged commit 57b5ff9 into master Jun 23, 2023
@mgeplf mgeplf deleted the increase-swc-unknown branch June 23, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherioszisis eleftherioszisis eleftherioszisis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgeplf @eleftherioszisis