Skip to content

Commit

Permalink
Allow port in hostname only config
Browse files Browse the repository at this point in the history
  • Loading branch information
@samwiseg0
samwiseg0 committed Dec 23, 2018
1 parent aa0ded3 commit c28dee4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion varken/iniparser.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def url_check(self, url=None, include_port=True):

search = (r'(?:([a-z0-9]+(-[a-z0-9]+)*\.)+[a-z]{2,}|' # domain...
r'localhost|' # localhost...
r'^[a-zA-Z0-9_-]*$|'
r'^[a-zA-Z0-9_-]*|'
r'\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3})' # ...or ip
)

Expand Down

3 comments on commit c28dee4

@GilbN
Copy link

@GilbN GilbN commented on c28dee4 Dec 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about hostname:port/base ?

@samwiseg0
Copy link
Member Author

@samwiseg0 samwiseg0 commented on c28dee4 Dec 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you saying this because you tested it?

Btw that works ;)

@GilbN
Copy link

@GilbN GilbN commented on c28dee4 Dec 23, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was thinking about setting up custom docker network and I'm just wondering if this fix also allows base url.
Edit: Awesome thanks!

Please sign in to comment.