Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Handle GeoIP Downloads better #113

Closed
samwiseg0 opened this issue Mar 11, 2019 · 1 comment
Closed

[BUG] Handle GeoIP Downloads better #113

samwiseg0 opened this issue Mar 11, 2019 · 1 comment
Labels
bug Something isn't working in-next-release In the next release

Comments

@samwiseg0
Copy link
Member

samwiseg0 commented Mar 11, 2019 •
edited
Loading

Describe the bug
In certain scenarios the DB would fail to download. When this happens we would get stuck in a condition were the file would be deleted but would not be able to be downloaded. Now we fail in such a way where we keep the old DB if we fail to update or download.

Also the DB must be at least 60 days old before we attempt to update.
@samwiseg0 samwiseg0 added awaiting-triage Request awaiting triage bug Something isn't working in-next-release In the next release and removed awaiting-triage Request awaiting triage labels Mar 11, 2019
samwiseg0 added a commit that referenced this issue Mar 11, 2019
@samwiseg0
Rework DB downloader fixes #113
dd65fa2
@slimshizn
Copy link

Thanks for the update.

@Boerderij Boerderij locked and limited conversation to collaborators Mar 19, 2019
dirtycajunrice pushed a commit that referenced this issue Jun 24, 2019
@samwiseg0
Rework DB downloader fixes #113
3796b62
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working in-next-release In the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samwiseg0 @slimshizn