Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Ombi 4.0 does not work with Varken #186

Closed
andrewhansen86 opened this issue Dec 1, 2020 · 11 comments
Closed

[ENHANCEMENT] Ombi 4.0 does not work with Varken #186

andrewhansen86 opened this issue Dec 1, 2020 · 11 comments
Labels
approved Enhancement or request that was approved to be worked on enhancement New feature or request in-next-release In the next release

Comments

@andrewhansen86
Copy link

andrewhansen86 commented Dec 1, 2020

Logging throwing nearly continuous error over and over following recent updates pushed to apps.

2020-12-01 12:55:14 : ERROR : ombi : TypeError has occurred : new() got an unexpected keyword argument 'requestStatus' while creating OmbiMovieRequest structure for movie.

To reproduce:
-Unknown at this time, but happening continuously even after a Varken restart. It does seem to stop about 60seconds after restart. However it looks to log these same errors at every startup for first 60seconds or so.

Environment:
Docker - boerderij/varken latest

Other:
Looks to be very similar to bug #88 , and looking at varken/structures.py there is no entry for requestStatus for OmbiMovieRequest. It may be a new field.

@samwiseg0
Copy link
Member

Please provide more details. You completely ignored the issue template. Please go back and use the template.

@samwiseg0 samwiseg0 added the more-info-requested Waiting on more information label Dec 1, 2020
@andrewhansen86
Copy link
Author

Edited original post and used issue template. Not sure how I missed the template the first time.

@samwiseg0
Copy link
Member

What version of Ombi are you running?

@andrewhansen86
Copy link
Author

For Ombi I am running 4.0.731.0

@samwiseg0
Copy link
Member

4.0 is currently unsupported. There were changes to the API and since the developer did not version the API that is why it is broken. We may eventually support it but it might be a while since 4.0 has had countless issues.

@samwiseg0 samwiseg0 added enhancement New feature or request and removed more-info-requested Waiting on more information labels Dec 3, 2020
@andrewhansen86
Copy link
Author

andrewhansen86 commented Dec 3, 2020

It is? The v4 branch is listed as the default branch on github now. I know it was beta for a while, but I thought it was the stable branch now.

https:/tidusjar/Ombi/branches

@samwiseg0 samwiseg0 changed the title Unexpected keyword argument 'requestStatus' while creating OmbiMovieRequest structure for movie. [ENHANCEMENT] Ombi 4.0 does not work with Varken Dec 3, 2020
@samwiseg0
Copy link
Member

samwiseg0 commented Dec 3, 2020

I have seen many complaints about 4.0 and frankly since the developer decided to change the API and not version it like he was supposed to I have not bothered to try and fix it. They should not have just broken the API for older apps.

@andrewhansen86
Copy link
Author

ok, good to know I may go back to the v3 branch for the time being then. Appreciate you getting to the bottom of it.

@PrivatePuffin

This comment has been minimized.

@samwiseg0

This comment has been minimized.

@samwiseg0 samwiseg0 added approved Enhancement or request that was approved to be worked on help-wanted Extra attention is needed labels Dec 4, 2020
@PrivatePuffin
Copy link

@samwiseg0 I was not asking for "support", I have it running for ages already.
I was saying that the supported and not supported software versions should be documented in the readme.

@samwiseg0 samwiseg0 added in-next-release In the next release and removed help-wanted Extra attention is needed labels Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Enhancement or request that was approved to be worked on enhancement New feature or request in-next-release In the next release
Projects
None yet
Development

No branches or pull requests

3 participants