Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] unexpected keyword argument 'channel_icon' #73

Closed
HangGlidersRule opened this issue Dec 27, 2018 · 3 comments
Closed

[BUG] unexpected keyword argument 'channel_icon' #73

HangGlidersRule opened this issue Dec 27, 2018 · 3 comments
Labels
bug Something isn't working in-next-release In the next release

Comments

@HangGlidersRule
Copy link

Describe the bug
When streaming live TV in Plex via the HDHR Viewer 2 plugin Varken fails to load the channel_icon key from Tautulli causing all metrics to be lost.

To Reproduce
Steps to reproduce the behavior:

  1. Watch live TV via HDHR Viewer
  2. Check Varken logs
  3. Be sad when it's broken

Expected behavior
Varken should discard unexpected keys with a warning instead of a halt allowing metrics to be collected even in edge cases with custom configurations adding unknown keys to the stream.

Screenshots
2018-12-26 19:14:19 : INFO : __init__ : Running job Every 30 seconds do threaded(<bound method TautulliAPI.get_activity of <tautulli-1>>) (last run: 2018-12-26 19:13:49, next run: 2018-12-26 19:14:19) 2018-12-26 19:14:19 : ERROR : tautulli : TypeError has occurred : __new__() got an unexpected keyword argument 'channel_icon' while creating TautulliStream structure

Environment (please complete the following information):

  • OS: Docker:master
  • Version v1.4

Additional context
https:/zynine-/HDHRViewerV2.bundle

@HangGlidersRule HangGlidersRule added the awaiting-triage Request awaiting triage label Dec 27, 2018
@samwiseg0
Copy link
Member

What is contained in channel_icon? Is it a string, integer, etc?

You can find the actual data in Tautulli by clicking in the word STREAM in the activity card.

@samwiseg0 samwiseg0 added bug Something isn't working more-info-requested Waiting on more information and removed awaiting-triage Request awaiting triage labels Dec 27, 2018
@HangGlidersRule
Copy link
Author

HangGlidersRule commented Dec 27, 2018

channel_icon is a string

Here is the output for the three channel_* keys -

"channel_icon": "http://resources-cdn.plexapp.com/image/source/com.plexapp.plugins.hdhrviewer.v2.jpg?h=None", "channel_stream": 1, "channel_title": "20:00 - 21:00: Anderson Cooper 360",

samwiseg0 added a commit that referenced this issue Dec 27, 2018
@samwiseg0
Copy link
Member

Fixed in nightly

@samwiseg0 samwiseg0 added in-next-release In the next release and removed more-info-requested Waiting on more information labels Dec 27, 2018
@Boerderij Boerderij locked and limited conversation to collaborators Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working in-next-release In the next release
Projects
None yet
Development

No branches or pull requests

3 participants