Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose native layer Integration Validator #1038

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rob-gioia-branch
Copy link

Reference

No ticket. Done to make it easier for clients to test & validate their Branch integration.

Summary

Exposed the native Android and iOS validators so that customers can make a single call at the JS layer to run the validator on whatever platform their app is running on.

Motivation

Currently, there is no way to run the Integration Validator from JS code. We have to tell clients to edit the native code, which isn't ideal and gets pushback from some customers. Others are confused as to how to do that. With this change, clients can run one line of code branch.validateSDKIntegration() to use the Integration Validator.

Type Of Change

  • New feature (non-breaking change which adds functionality)

Testing Instructions

  • Run this line of code in your sample / test bed app: branch.validateSDKIntegration();

cc @BranchMetrics/saas-sdk-devs for visibility.

…settings.gradle

Fixed an Android build error by using @react-native/gradle-plugin in settings.gradle
…egration" button in there

Added a testing section to the App.tsx file with an "Validate SDK Integration" button in there
Got the validator working for Android
Got the validator working for iOS
Updated packages-lock file (fixed build error)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant