Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config referencing nonexistent CDF source leads to uncaught exception #347

Closed
tarheel opened this issue Jul 7, 2019 · 1 comment
Closed

Comments

@tarheel
Copy link
Contributor

tarheel commented Jul 7, 2019

Example:

2019-07-06 22:33:50 PDT INFO: Successfully loaded contest config: /Users/leisenberg/code/rcv/src/test/resources/network/brightspots/rcv/test_data/test_set_treat_blank_as_undeclared_write_in/test_set_treat_blank_as_undeclared_write_in_config.json
2019-07-06 22:33:50 PDT SEVERE: Error opening file: /Users/leisenberg/code/rcv/src/test/resources/network/brightspots/rcv/test_data/test_set_treat_blank_as_undeclared_write_in/test_set_0_skipped_first_choice_cvr.json
java.io.FileNotFoundException: /Users/leisenberg/code/rcv/src/test/resources/network/brightspots/rcv/test_data/test_set_treat_blank_as_undeclared_write_in/test_set_0_skipped_first_choice_cvr.json (No such file or directory)
Check file path and permissions and make sure they are correct!
2019-07-06 22:33:50 PDT SEVERE: Error parsing candidate data: java.lang.NullPointerException

I guess it basically handles it fine, but maybe we should clean up the log messages a bit.

@tarheel
Copy link
Contributor Author

tarheel commented Aug 5, 2020

At some point we updated the validation logic to complain if a source file is nonexistent, so there's nothing left to do here.

@tarheel tarheel closed this as completed Aug 5, 2020
@HEdingfield HEdingfield modified the milestones: v1.x Future, v1.2 Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants