Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate MigrationHelper class #507

Closed
HEdingfield opened this issue Sep 21, 2020 · 0 comments
Closed

Create separate MigrationHelper class #507

HEdingfield opened this issue Sep 21, 2020 · 0 comments

Comments

@HEdingfield
Copy link
Contributor

The migration logic currently lives in GuiConfigController.migrateConfigVersion. We should create a separate (probably static util) class to contain this logic because, as is stands, I don't believe any of the version migration logic works for CLI uses of the tool. Other notes / requirements:

  • We may need to add a new CLI flag to handle this, and I think we'll need to make sure it doesn't trigger for version "TEST".
  • It should probably also check if going from a future version to a past version and if so, completely bail (we'd need to split on . for the version number then compare biggest number first, middle, then smallest).
  • Also test garbage values / words in the version field to make sure the version number comparison fails gracefully.

A stopgap in the meantime if the all of the above isn't immediately doable: add a note saying you can't run this because you're in the CLI and you need to use GUI to migrate the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants