Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sundry UX fixes #509

Merged
merged 7 commits into from
Sep 22, 2020
Merged

Sundry UX fixes #509

merged 7 commits into from
Sep 22, 2020

Commits on Sep 20, 2020

  1. Clarified language to address confusing UX in passesBasicCvrSourceVal…

    …idation(): I was putting a letter in precinct column and in file source and it says "precinctColumnIndex must be an integer from 1 to 1000 if supplied: b", making it seem like the letter I had put in precinctColumn was b when it was something else ("b" was the file source dummy value I had used).
    HEdingfield committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    c240700 View commit details
    Browse the repository at this point in the history
  2. Adds suggested values for overvoteLabel, undervoteLabel, and ES&S col…

    …umn and row indices as requested by @chughes297 (overriding what was in the original GUI mock-ups).
    HEdingfield committed Sep 20, 2020
    Configuration menu
    Copy the full SHA
    22df8e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Converts overvoteRule from a ChoiceBox to an array of RadioButtons; c…

    …hanges overvoteRule string display in config files and adds migration logic.
    HEdingfield committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    c057e4e View commit details
    Browse the repository at this point in the history
  2. Fix tests.

    HEdingfield committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    a2b3bc5 View commit details
    Browse the repository at this point in the history
  3. Disables decimalPlacesForVoteArithmetic and `nonIntegerWinningThres…

    …hold` except when `winnerElectionMode` is "Multi-winner allow only one winner per round" or "Multi-winner allow multiple winners per round" (fixes #500).
    HEdingfield committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    5dc57b7 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Fixes ToggleGroup bug introduced by IntelliJ code rearrange, and clea…

    …rs labels from radio buttons so they can be programmatically defined.
    HEdingfield committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    cd20c53 View commit details
    Browse the repository at this point in the history
  2. Refactors OvervoteRule text entries as constants so they can be direc…

    …tly referenced in the GUI and validation warnings.
    HEdingfield committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    60e7218 View commit details
    Browse the repository at this point in the history