allow batch elimination and "continue until two candidates remain" to be enabled in multi-pass IRV mode #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moldover
previously approved these changes
Aug 11, 2022
moldover
dismissed
their stale review
I forgot that you're going to add a test first.
… be enabled in multi-pass IRV mode
|
test added |
|
This looks like a good test and code change. |
|
Yes, I can rename them. I have to force push after I rebase an open PR on main. I know doing a merge commit is also an option, but I prefer this workflow, though I admit it's not perfect. |
moldover
approved these changes
Aug 17, 2022
Don't let perfect be the enemy of the good. They should be friends. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To refresh everyone's memory: "multi-pass IRV" is an especially silly form of multi-winner RCV in which you run a series of single-winner elections, excluding the candidates who have already won from each subsequent pass. So this filed issue is correct that there's no reason you shouldn't be able to enable these options for this election mode.
I'll also add a test for this one when I figure out that process.
Fixes #556.