Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Copy window example from SvelteKit implementation docs #578

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

cornedor
Copy link
Contributor

@cornedor cornedor commented Apr 8, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Copy information about explicitly adding functions to window from SvelteKit docs.

Use cases and why

This is related to all frameworks

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 11:04am

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, thanks @cornedor

@gioboa gioboa merged commit 710ea8d into BuilderIO:main Apr 10, 2024
10 checks passed
benmccann added a commit to benmccann/partytown that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants