Fix color scheme for light terminals #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by making sure that we never have a background that is black or white combined with a foreground that uses the terminal's default and vice versa. Because we cannot access the default terminal colors, we have to rely on inverted colors and bold text for highlighting. Also, the mark pane was improved to be more consistent with the entries pane. Ideally, we would use the same color as in the entries pane, but this is currently not possible, because the mark pane does not know whether a path is a directory or not. Fixes Byron#13.
This required passing the information whether a path is a directory accordingly.
ghost
merged commit 
|
Awesome, thank you so much! I will cut a new release today :). |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13.
Due to the way colors work in the terminal, I had to change the color scheme for dark terminals as well.
I also tried to make the coloring of the entries and the mark pane more consistent.