[DEV-7737] Responsive Editor #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adamdoe
commented
Apr 4, 2024
•
adamdoe
commented
- While on a visualization, press escape key to open the responsive editor view.
- Verify visualizations look correct outside editor view.
* [responsive-editor__styles] 4.24.4 > Responsive Editor Styles * [responsive-editor__styles] update data bite * [responsive-editor__styles] 4.24.4 > continue working on styles for responsive editor * [responsive-editor__styles] working on mu include * [responsive-editor__styles] Full width charts * [responsive-editor__styles] 4.24.4 > Responsive Maps * [responsive-editor__styles] add responsive view for data bite * [responsive-editor__styles] Waffle Chart > Add responsive work * [responsive-editor__styles] Markup Include > Responsive Additions * [responsive-editor__styles] 4.24.4 > Responsive pixel numbers * [responsive-editor__styles] fixing file issues * [responsive-editor__styles] working on editor issues * [responsive-editor__styles] working on cove styles * [responsive-editor__styles] update map error component * [responsive-editor__styles] markup include layout updates * [responsive-editor__styles] start work with confirm/error * [responsive-editor__styles] start work with confirm/error * [responsive-editor__styles] Resolve responsive issues * [responsive-editor__styles] continue working on wrappers * [responsive-editor__styles] continue working on wrappers
joshlacey
reviewed
Apr 4, 2024
packages/core/components/Layout/components/Sidebar/components/Sidebar.tsx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,914 @@ | |||
| @import '@cdc/core/styles/v2/themes/_color-definitions.scss'; | |||
|
|
|||
There was a problem hiding this comment.
can you write this is common CSS?
There was a problem hiding this comment.
I think we can later on but that's outside of the scope of this ticket.
packages/core/components/Layout/components/Visualization/visualizations.scss
Outdated
Show resolved
Hide resolved
| @@ -10,6 +10,11 @@ | |||
| margin-top: 20%; | |||
| } | |||
|
|
|||
| > .cove-editor__content { | |||
| width: 100% !important; | |||
There was a problem hiding this comment.
I've seen width: 100% !important; under another class declaration that had .cove-editor__content
|
|
||
| if (columnList.length === 0) columnList = null | ||
|
|
||
| setRequiredColumns(columnList) |
There was a problem hiding this comment.
I feel like you could put this in a useMemo rather than having to setState?
| ) | ||
| } | ||
|
|
||
| const Confirm = () => { |
There was a problem hiding this comment.
This Error / Confirm is starting to look repetitive
|
@adamdoe can the new json config files be added to storybook instead of in the examples folder? It's difficult to test when they are examples |
|
@Atash3000 and @mpallansch can you both do a pass on this as well? |
|
@mpallansch and @Atash3000 see above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.