Fix: [dev-7840] respiratory regression #1277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamdoe
approved these changes
May 14, 2024
adamdoe
approved these changes
May 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression which is detailed by Matt Pallansch in the original ticket comments for DEV-7840
Fixes breaking change for API filters introduced by dev-8065
Removes broken Storybook pages caused by a combination of scss support and importing markdown into mdx file. detailed here: [Bug]: Cannot read properties of undefined (reading 'fonts') with
addon-docsstorybookjs/storybook#23868 If we want these pages to remain I'd probably just have a single into page which links out to our github repo instead of trying to include the markdown.removes the ability to switch dashboard filter types after the filter has been saved. This will allow us to keep the configurations for each filter type distinct and avoid future bugs. I noticed in the respiratory example mentioned in DEV-7840 that there was some configuration for a data filter and some for a url filter.