Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-8314] 4.24.6 > Update Sankey messaging #1347

Merged
merged 1 commit into from
Jun 12, 2024
Merged

[DEV-8314] 4.24.6 > Update Sankey messaging #1347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/chart/src/components/EditorPanel/components/Panels/Panel.Sankey.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ const SankeySettings = () => {
<AccordionItemButton>Sankey Settings</AccordionItemButton>
</AccordionItemHeading>
<AccordionItemPanel>
<p>Node stories can provide additional details to support public health messaging. COVE can display a maximum of 3 node stories.</p>
{data?.storyNodeText &&
data?.storyNodeText.map(({ StoryNode, segmentTextBefore, segmentTextAfter }, i) => (
<div key={i} style={{ border: '1px solid black', margin: '15px auto', padding: '15px', borderRadius: '10px' }}>
Expand All @@ -84,7 +85,6 @@ const SankeySettings = () => {
</Button>
</div>
))}
{`Total Story Nodes: ${data?.storyNodeText?.length}`}
{data?.storyNodeText?.length < 3 && (
<button
type='button'
Expand All @@ -97,7 +97,6 @@ const SankeySettings = () => {
Add StoryNode
</button>
)}

<CheckBox value={config.enableTooltips} fieldName='enableTooltips' label='Enable Tooltips' updateField={updateField} />
</AccordionItemPanel>
</AccordionItem>
Expand Down
4 changes: 2 additions & 2 deletions packages/dashboard/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</head>

<body>
<!-- <div class="react-container" data-config="/examples/full-dashboard.json"></div> -->
<div class="react-container" data-config="/examples/default-multi-dataset.json"></div>
<!-- <div class="react-container" data-config="/examples/dashboard-gallery.json"></div> -->
<!-- <div class="react-container" data-config="/examples/filtered-dash.json"></div> -->
<!-- <div class="react-container" data-config="/examples/all-components.json"></div> -->
Expand All @@ -34,7 +34,7 @@

<!-- Respiratory custom example -->
<div class="react-container wcms-viz-container" data-config-url="/respiratory-viruses/modules/ed-visits-county-file.json" data-config="/examples/ed-visits-county-file.json"></div>

<script src="https://www.cdc.gov/TemplatePackage/contrib/libs/jquery/latest/jquery.min.js?_=91329"></script>
<!-- <script src="examples/custom/js/respiratory.js"></script> -->

Expand Down