Enhancement: [dev-8903] dropdown styling #1555
Conversation
| > | ||
| <Icon display={expanded ? 'caretDown' : 'caretUp'} style={{ cursor: 'pointer' }} /> |
There was a problem hiding this comment.
I'm assuming they don't want the caretUp here anymore for ux reasons.
There was a problem hiding this comment.
yes that was as per the prototype.
| @@ -88,15 +88,24 @@ type IconProps = { | |||
| /* Returns icon data as plain svg */ | |||
| base?: boolean | |||
| /* Sets alt text for the icon */ | |||
| alt: string | |||
| alt?: string | |||
There was a problem hiding this comment.
We might want to keep this requirement for 508.
There was a problem hiding this comment.
I think having a different description of a checkmark throughout the app might be worse than defaulting to checkmark. I could create a new lookup with default names for each of the icons? so it doesn't end up as 'caretUp'.
const defaultNameLookup = { caretUp: 'caret up'}
<IconObj title={ alt || defaultNameLookup[display] } />
if you think this is necessary. I just kept seeing a lot of places where the alt wasn't given and we had typescript errors.
joshlacey
force-pushed
the
enhancement/dev-8903-dropdown-styling
branch
from
cdd7d8c
to
4956282
Compare
[Replace With Ticket Number]
Testing Steps
Self Review
Screenshots (if applicable)
Additional Notes