Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-9399] Update legend items #1566

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[DEV-9399] Update legend items #1566

merged 1 commit into from
Oct 7, 2024

Conversation

Atash3000
Copy link
Collaborator

[Replace With Ticket Number]

Fixed small bugs on Legend suppression and also update styling from css to bootstrap classes to align legend lines.
Testing steps:
Open line chart
On legend panel select Legend Styles ==> "Lines" style.
And Lines has to be properly aligned with labels.

Testing Steps

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@Atash3000 Atash3000 added this to the 4.24.10 milestone Oct 7, 2024
@joshlacey
Copy link
Collaborator

what does it mean "properly aligned with labels?" This is what I'm seeing:

image

@joshlacey joshlacey self-requested a review October 7, 2024 16:27
@joshlacey joshlacey merged commit 88e4dbd into dev Oct 7, 2024
1 check passed
@Atash3000 Atash3000 deleted the feature/DEV-9399 branch October 8, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants