Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev 9406 #1573

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Dev 9406 #1573

wants to merge 2 commits into from
+57 −8

Conversation

mpallansch
Copy link
Collaborator

DEV-9406

Testing Steps

  1. Run editor
  2. Create bar chart with single series
  3. In series settings, change rank by value to the different options and ensure they sort the x axis point appropriately
  4. Return to data import tab, then back to configure and ensure setting remains

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

joshlacey
joshlacey reviewed Oct 10, 2024
View reviewed changes
packages/chart/src/CdcChart.tsx
return Number(number)
}

const handleRankByValue = (data, passedConfig = config) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pull these out into helper functions and add unit tests?

joshlacey
joshlacey reviewed Oct 10, 2024
View reviewed changes
packages/chart/src/components/EditorPanel/EditorPanel.tsx
return -1
}

const updateFieldRankByValue = (section, subsection, fieldName, newValue) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you pull this and indexOfObj out into helper functions and add unit tests?

@adamdoe
Copy link
Collaborator

adamdoe commented Oct 16, 2024

@mpallansch can you see @joshlacey 's comments on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshlacey joshlacey joshlacey left review comments

@adamdoe adamdoe Awaiting requested review from adamdoe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mpallansch @adamdoe @joshlacey