Fix: DEV-9358 Advanced Editor: Multidashboard changes not saving #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt-DiPaolo
force-pushed
the
dev-9358-Advanced-Editor-MultiDashboard-changes-not-saving
branch
from
5f0ebd6
to
c833c0d
Compare
joshlacey
reviewed
Oct 18, 2024
packages/dashboard/src/components/VisualizationsPanel/VisualizationsPanel.tsx
Outdated
Show resolved
Hide resolved
Matt-DiPaolo
force-pushed
the
dev-9358-Advanced-Editor-MultiDashboard-changes-not-saving
branch
from
c833c0d
to
83c5c5b
Compare
joshlacey
changed the title
joshlacey
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://websupport.cdc.gov/projects/DEV/issues/DEV-9358
When making a change to any multidashboard via the advanced editor the changes are saved and apply.
Testing Steps
Scenario: Open a Default Editor and choose the Dashboard Viz and open the Configuration tab,
Expected: The visualization on the right will be populated with the information in the dev-9358-Multidashboard.json file.
Self Review