Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dev 6966 tables styling #1592

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

adamdoe
Copy link
Collaborator

@adamdoe adamdoe commented Oct 18, 2024

[DEV-6966] Preview Styling Updates

  • Remove thead-dark class to get blue styling
  • Verify teahd-dark class wasn't being used anywhere
  • Make preview table 100% width
  • Add slight margin above the table
  • Change scroll behavior to default

Testing Steps

  • Open the editor
  • Import any data set
  • Verify the table takes up 100% of the width it normally should
  • Verify the table has the blue theme that matches visualization data tables

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Screen Shot 2024-10-18 at 9 35 08 AM

Additional Notes

joshlacey and others added 4 commits October 9, 2024 16:16
- Remove thead-dark class to get blue styling
- Verify teahd-dark class wasn't being used anywhere
- Make preview table 100% width
- Add slight margin above the table
- Change scroll behavior to default
@adamdoe adamdoe added this to the 4.24.10 milestone Oct 18, 2024
@adamdoe adamdoe merged commit d11cc60 into dev Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants