Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor [DEV-9340] feedback to rename to "Tick labels on top of gridlines" #1598

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Refactor [DEV-9340] feedback to rename to "Tick labels on top of gridlines" #1598

merged 2 commits into from
Oct 21, 2024

Conversation

Mgetz10
Copy link
Collaborator

@Mgetz10 Mgetz10 commented Oct 21, 2024

DEV-9340

Rename from "Labels above gridlines" to "Tick labels on top of gridlines"

Testing Steps

  1. Open the editor
  2. Make a bar or line chart
  3. Open the "Left Value Axis" panel
  4. Observe the field is now called "Tick labels on top of gridlines"

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Screenshot 2024-10-21 at 10 03 40 AM

@Mgetz10 Mgetz10 requested a review from jayb October 21, 2024 14:04
jayb
jayb approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@jayb jayb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mgetz10 Mgetz10 merged commit f97bdc7 into dev Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayb jayb jayb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mgetz10 @jayb