Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix [dev-9566] table columns sizing #1601

Merged
merged 2 commits into from
Oct 22, 2024
Merged

fix [dev-9566] table columns sizing #1601

merged 2 commits into from
Oct 22, 2024
+27 −37

Conversation

joshlacey
Copy link
Collaborator

[Replace With Ticket Number]

Table columns were collapsing with asterisks to the right when on mobile, this fixes that an makes it scroll instead of collapsing.

Testing Steps

Self Review

  • I have added testing steps for reviewers
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests are passing

Screenshots (if applicable)

Additional Notes

@joshlacey joshlacey added this to the 4.24.10 milestone Oct 21, 2024
jayb
jayb approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@jayb jayb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you.

@joshlacey joshlacey merged commit 5b6c885 into dev Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayb jayb jayb approved these changes

@adamdoe adamdoe Awaiting requested review from adamdoe

@Atash3000 Atash3000 Awaiting requested review from Atash3000

@Matt-DiPaolo Matt-DiPaolo Awaiting requested review from Matt-DiPaolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.24.10
Development

Successfully merging this pull request may close these issues.
2 participants
@joshlacey @jayb