-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Step Counter to new workflow #20
Merged
robertandremitchell
merged 55 commits into
main
from
bob/2559-step-counter-implementation
Oct 21, 2024
Merged
Adding Step Counter to new workflow #20
robertandremitchell
merged 55 commits into
main
from
bob/2559-step-counter-implementation
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lessly use new structure
….com/CDCgov/dibbs-query-connector into bob/2559-step-counter-implementation
… on search form, removing advanced button from select query
…om/CDCgov/dibbs-query-connector into bob/2663-customize-query-alignment
fzhao99
reviewed
Oct 17, 2024
fzhao99
reviewed
Oct 17, 2024
fzhao99
reviewed
Oct 17, 2024
query-connector/src/app/query/components/searchForm/SearchForm.tsx
Outdated
Show resolved
Hide resolved
fzhao99
reviewed
Oct 17, 2024
…counter-implementation
fzhao99
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few suggestions but overall looks great! Worth tagging Michelle for a design review too and filling out the section for what she should look for in the PR template
query-connector/src/app/query/components/searchForm/SearchForm.tsx
Outdated
Show resolved
Hide resolved
fzhao99
reviewed
Oct 17, 2024
fzhao99
reviewed
Oct 17, 2024
Co-authored-by: fzhao99 <[email protected]>
Co-authored-by: fzhao99 <[email protected]>
…into bob/2559-step-counter-implementation
….com/CDCgov/dibbs-query-connector into bob/2559-step-counter-implementation
fzhao99
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
This adds the step counter to the work @fzhao99 has done on connecting our new component pages.
Related Issue
Fixes #2559
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review
Additional Information
Anything else the review team should know?
Checklist