Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query flow redirect followup #37

Merged
merged 22 commits into from
Oct 21, 2024
Merged

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Oct 18, 2024

PULL REQUEST

Summary

Followup to the fixes to the other PR that went in that

  • Changes the default medication admin request to be more in line with what was intended (thanks Marcelle!)
  • Fixed the copy for the redirect toast between customize query --> select query
  • Standardizes the spacing within and between page grouped page elements (to 12px / 40px respectively, as defined in their variables within _variables.scss)
  • Defines some site-wide width defaults (main-container and main-container__wide) for the types of pages we have based on a convo with Michelle (ie the classes in layouts.scss that we're deriving from some tokenized width values)
  • Added some code in the ResultsView that will filter out columns for display if there's nothing to display
  • Moves the page files into the folders that are there to make them easier to find
  • Some styling quality of life cleanup / definition

Related Issue

Will fix phdi 2663 and phdi 2710

Acceptance Criteria

Got an OK from Michelle synchronously

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@fzhao99 fzhao99 marked this pull request as ready for review October 18, 2024 17:34
@fzhao99 fzhao99 changed the title Bob/2663 query flow redirect followup query flow redirect followup Oct 18, 2024
Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good, a few variable name q's

@fzhao99 fzhao99 enabled auto-merge (squash) October 21, 2024 15:56
@fzhao99 fzhao99 merged commit a603b84 into main Oct 21, 2024
4 checks passed
@fzhao99 fzhao99 deleted the bob/2663-query-flow-redirect-followup branch October 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants