add translation function: vsac --> internal valueset #41
Conversation
fzhao99
requested review from
m-goggins,
bamader,
robertandremitchell and
DanPaseltiner
and removed request for
m-goggins and
bamader
| // includeValueSet: boolean; | ||
| // concepts: Concept[]; | ||
| // } | ||
| export interface InternalValueSet { |
There was a problem hiding this comment.
Can change this once I sync up with Brandon on 2789
| ersdConceptType: ErsdConceptType, | ||
| ) { | ||
| const id = fhirValueset.id; | ||
| // does this need any interpolation? |
There was a problem hiding this comment.
Would love answers on this and other questions here! Will remove these once we get them answered
There was a problem hiding this comment.
hm, could be worth adding, but I don't think we need to have v2/v3. I think we are using v3, which is backwards compatible with v2. Ideally, any future versions would maintain that, but out of full caution, could be worth not making that assumption.
|
|
||
| // would we prefer this over the less readable "name?" | ||
| // ie "name": "ChlamydiaTrachomatisInfectionOrganismOrSubstanceInLabResults", | ||
| // "title": "Chlamydia trachomatis Infection (Organism or Substance in Lab Results)", |
There was a problem hiding this comment.
you are correct, I think we always care about title over name for legibility.
| ersdConceptType: ErsdConceptType, | ||
| ) { | ||
| const id = fhirValueset.id; | ||
| // does this need any interpolation? |
There was a problem hiding this comment.
hm, could be worth adding, but I don't think we need to have v2/v3. I think we are using v3, which is backwards compatible with v2. Ideally, any future versions would maintain that, but out of full caution, could be worth not making that assumption.
PULL REQUEST
Summary
Adds a translation function / stubs out a test for translating a VSAC ValueSet response into our internal ValueSet type.
Related Issue
Fixes #phdi 2792
Acceptance Criteria
Since we will use ValueSet internally to model valuesets within the application and we will receive valuesets in a FHIR format from VSAC and possibly other terminology services in the future we need a way to transfrom from FHIR to our ValueSet model.
Additional Information
Left a slew of questions in the translation function that'd love feedback on!