Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data type validation to AzureCloudContainerConnection.upload_object() #352

Open
DanPaseltiner opened this issue Dec 1, 2023 · 0 comments
Labels

Comments

@DanPaseltiner
Copy link
Collaborator

DanPaseltiner commented Dec 1, 2023

The upload_object() method on the AzureCloudContainerConnection class allows users to write data to Azure blob storage. Currently we support this data being provided as either a string or dictionary. However, we do not currently validate the type of message argument to ensure that it is either str or dict. This results in the failing silently when the type of message is anything else e.g. None. To resolve this we should implement some data type validation on message so that when it is a type not currently supported by upload_object() we raise an exception.

Acceptance Criteria:

GIVEN the AzureCloudContainerConnection class
WHEN the upload_object() method is called with a value for message that is not str or dict
THEN a ValueError exception is raised that clearly explains the issue to the user

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant