Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoint in the Trigger Code Reference service #2123

Closed
5 tasks
gordonfarrell opened this issue Jul 12, 2024 · 0 comments · Fixed by #2238
Closed
5 tasks

Update endpoint in the Trigger Code Reference service #2123

gordonfarrell opened this issue Jul 12, 2024 · 0 comments · Fixed by #2238
Assignees
Labels
Streamline eCR Issues for Streamline eCR team to work on

Comments

@gordonfarrell
Copy link
Collaborator

gordonfarrell commented Jul 12, 2024

Action Requested

We need to make some additions in the Trigger Code Reference building block to better suit our needs. We need to update the endpoint so rather than sending a list of codes to stamp, it automatically looks inside in the bundle for the reportable condition codes from the Reportability Response (RR), then stamps the eCR with those conditions.

Acceptance Criteria

In the endpoint:

  • The RR condition codes are extracted from the FHIR bundle
  • The TCR then stamps the bundle with each of those codes
  • The stamped bundle is returned in the response from the endpoint
  • It no longer needs/accepts a list of conditions sent it alongside the FHIR bundle
  • Unit tests for all functions

Testing

Yes, this ticket requires unit tests for new functions. No integration tests yet as that will come in in the next ticket.

Designs

No as this is entirely backend

Background & Context

The current stamping endpoint on the TCR isn't ideal for us as it requires us to pass in a list of conditions to the endpoint. We don't want to do this code gathering and passing in orchestration because it adds complexity and makes orchestration "too smart" when it should just be passing around bundles and calling endpoints. This change will let us do all the work in the TCR to keep orchestration simple.

@gordonfarrell gordonfarrell added the Streamline eCR Issues for Streamline eCR team to work on label Jul 12, 2024
@gordonfarrell gordonfarrell changed the title Add new endpoint to the Trigger Code Reference service Update endpoint to the Trigger Code Reference service Jul 15, 2024
@gordonfarrell gordonfarrell changed the title Update endpoint to the Trigger Code Reference service Update endpoint in the Trigger Code Reference service Jul 15, 2024
@JNygaard-Skylight JNygaard-Skylight self-assigned this Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Streamline eCR Issues for Streamline eCR team to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants