Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seed-data script to use save data endpoint #2368

Closed
2 tasks
emmastephenson opened this issue Aug 9, 2024 · 3 comments · Fixed by #2640
Closed
2 tasks

Update seed-data script to use save data endpoint #2368

emmastephenson opened this issue Aug 9, 2024 · 3 comments · Fixed by #2640
Assignees
Labels
pairing Streamline eCR Issues for Streamline eCR team to work on

Comments

@emmastephenson
Copy link
Collaborator

What needs to be done

Right now the seed script for the eCR Viewer manually saves data to the database, rather than using the endpoint on the eCR Viewer to do so. It needs to use the endpoint.

Why it needs to be done

In a deployed scenario, the eCR Viewer is the final phase of the pipeline - it saves both metadata and blob storage for future reading. Right now our seed script doesn't match this user pattern, and instead directly saves data to the database without using the Viewer's endpoint. Since the seed script is the backbone of our local development, this means we're not testing and using the application in the way our users will - which we need to fix.

Acceptance Criteria

  • Orchestration configuration for seed-data is updated to call the eCR Viewer's save data endpoint directly
  • There is NO manual writing to the SQL table in the seed script (excepting any database table setup). Only the Viewer's endpoints are used to interact with the database.

Technical Notes

Handy links:

@emmastephenson emmastephenson added the Streamline eCR Issues for Streamline eCR team to work on label Aug 9, 2024
@emmastephenson
Copy link
Collaborator Author

Considerations from Planning:

  • May need to update orchestration service to handle eCR Viewer endpoint
  • Need to think about how seed-data interacts with testing config/setup

@lina-roth lina-roth assigned lina-roth and unassigned lina-roth Aug 15, 2024
@angelathe angelathe self-assigned this Aug 19, 2024
@angelathe
Copy link
Collaborator

One more acceptance criteria - Need to remove extraneous schema definitions in 01-init.sql in this ticket (see link)

@angelathe
Copy link
Collaborator

Putting this back into the backlog - still blocked by 2367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pairing Streamline eCR Issues for Streamline eCR team to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants