Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly find reportable conditions #2338

Merged
merged 11 commits into from
Aug 14, 2024

Conversation

JNygaard-Skylight
Copy link
Collaborator

@JNygaard-Skylight JNygaard-Skylight commented Aug 7, 2024

PULL REQUEST

Summary

Uses the reportable conditions section to find the SNOMED codes of those conditions

Related Issue

Fixes #2331

Additional Information

I'm unsure how best to test this, as there appear to be several issues with reportable conditions, stamping relevant labs, etc.

Check the eCR pictured, and similar conditions and lab should be listed in the summary.
Screenshot 2024-08-07 at 17 12 07
Screenshot 2024-08-07 at 17 12 17
Screenshot 2024-08-07 at 17 11 51

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good start, but let's switch over to using fhirpathpy since it excels in this area and will be more robust in the long term.

containers/trigger-code-reference/app/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Looks great! Thanks for making that change to fhirpathpy. That'll ensure really fast compilation on the server side when we go to work with these codes, and now we'll be sure we get everything that the eHR flagged as reportable.

@JNygaard-Skylight JNygaard-Skylight added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 627f432 Aug 14, 2024
10 checks passed
@JNygaard-Skylight JNygaard-Skylight deleted the josh/correctly-find-reportable-conditions branch August 14, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCR Service Not Correctly Finding Reportable Conditions
3 participants