Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify playwright tests to accommodate modal view #2403

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

m-goggins
Copy link
Collaborator

@m-goggins m-goggins commented Aug 19, 2024

PULL REQUEST

Summary

Modifies the TEFCA playwright tests to include the modal view and make the appropriate selections. These tests were failing after the modal feature was introduced, which I believe was the source of the errors the streamline team found here. I'm not totally sure how the modal feature was added without the tests failing before this.

Related Issue

Fixes #

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link
Collaborator

@robertandremitchell robertandremitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@nickbristow nickbristow added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 95dea05 Aug 20, 2024
10 checks passed
@nickbristow nickbristow deleted the fix-playwright-tests-for-modal branch August 20, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants