Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new configuration for message parsing to support extended schema #2417

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Add new configuration for message parsing to support extended schema #2417

merged 3 commits into from
Aug 22, 2024

Conversation

lina-roth
Copy link
Collaborator

@lina-roth lina-roth commented Aug 21, 2024 •
edited
Loading

PULL REQUEST

Summary

  • Added philly_ecr.json

Related Issue

Fixes #2339

Test steps

  • Go to containers/orchestration/app/custom_configs/seed-ecr-viewer-config.json
  • Change line 34 "parsing_schema_name" to philly_ecr.json
  • Go to ecr-viewer, run npm run convert-seed-data
  • See that it succeeds and spits out a data.sql

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@lina-roth lina-roth changed the title Lr/philly schema Add new configuration for message parsing to support extended schema Aug 21, 2024
austin-hall-skylight
austin-hall-skylight approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@austin-hall-skylight austin-hall-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it and everything worked. Good to go!

@lina-roth lina-roth added this pull request to the merge queue Aug 22, 2024
Merged via the queue into main with commit 326b9e7 Aug 22, 2024
10 checks passed
@lina-roth lina-roth deleted the lr/philly-schema branch August 22, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin-hall-skylight austin-hall-skylight austin-hall-skylight approved these changes

@BobanL BobanL Awaiting requested review from BobanL

@angelathe angelathe Awaiting requested review from angelathe

@gordonfarrell gordonfarrell Awaiting requested review from gordonfarrell

@JNygaard-Skylight JNygaard-Skylight Awaiting requested review from JNygaard-Skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a new configuration for message parsing to support extended schema
2 participants
@lina-roth @austin-hall-skylight