Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read/write bundles to/from Azure Blob Storage #2425

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

angelathe
Copy link
Collaborator

@angelathe angelathe commented Aug 22, 2024

PULL REQUEST

Summary

What changes are being proposed?

  • Add functionality to read/write FHIR bundles to/from Azure blob storage
  • Add env vars
  • Add mock API tests

Note: Currently, we don't have access to Azure, so I used placeholder env vars and had to move a couple lines around so things wouldn't error out.

Related Issue

Fixes #2398

Checklist

Don't know what testing can currently be done without DIBBs access to Azure?

Acceptance Criteria

  • Adjust existing env vars or create a new one to allow configuring the app to save to Azure Blob storage rather than AWS
  • Implement an Azure Blob Storage read and write (See linked docs below)
  • Use conditional logic with the env var to save to blob storage when the app is configured for Azure
    Tests
  • S3 read and write should work as normal if the app is configured for AWS

@angelathe angelathe self-assigned this Aug 22, 2024
Copy link
Collaborator

@austin-hall-skylight austin-hall-skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Azure storage emulator and everything is working

Copy link
Collaborator

@gordonfarrell gordonfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, great work on this Angela! Just one tiny comment/question, gonna approve though so you don't have to hunt me down for a re-approval if it needs a change. Thanks!

@angelathe angelathe added this pull request to the merge queue Aug 27, 2024
Merged via the queue into main with commit 2e6d480 Aug 27, 2024
11 checks passed
@angelathe angelathe deleted the angela/2398-write-read-azure branch August 27, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement writing to and reading from Azure Blob Storage
4 participants