Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basepath support to eCR Viewer #2542

Merged
merged 11 commits into from
Sep 13, 2024
Merged

Add basepath support to eCR Viewer #2542

merged 11 commits into from
Sep 13, 2024

Conversation

angelathe
Copy link
Collaborator

@angelathe angelathe commented Sep 11, 2024

PULL REQUEST

Summary

Add basepath support to the eCR Viewer.

  • Add env var NEXT_PUBLIC_BASEPATH="/ecr-viewer"
  • Fix basepath references for orchestration integration tests, lighthouse tests, and Cypress e2e tests

Related Issue

Fixes #2536
Also related to #2397

Acceptance Criteria

  • Basepath support added to the application
  • New release cut (Can only be done after this PR and Fix S3 writes for running instances #2537 are merged to main)
  • AWS/Azure are running new code and working as intended (the Viewer can load)

Additional Information

Context:
Without basepath support, the eCR Viewer runs into gateway errors for our CSS/JS files when deployed to a cloud environment.

Testing

  • Try running the ecr-viewer in both production and dev modes
    • Production: npm run build then npm run start --> Visit http://localhost:3000/ecr-viewer
    • Dev: npm run local-dev --> Visit http://localhost:3000/

@angelathe angelathe self-assigned this Sep 11, 2024
@angelathe angelathe marked this pull request as ready for review September 11, 2024 16:46
@angelathe angelathe marked this pull request as draft September 11, 2024 17:48
Copy link
Collaborator

@emmastephenson emmastephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would also love a review from @nickbristow (or anyone with more FE expertise) as it's been a while since I was this in the weeds 😅

@nickbristow
Copy link
Collaborator

LGTM, but would also love a review from @nickbristow (or anyone with more FE expertise) as it's been a while since I was this in the weeds 😅

yeah, we paired on this to get it working! LGTM

@angelathe angelathe added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 961cc63 Sep 13, 2024
11 checks passed
@angelathe angelathe deleted the angela/2536-basepath branch September 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basepath support to eCR Viewer
3 participants