Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add step to build flyway container #2593

Merged
merged 13 commits into from
Sep 19, 2024
Merged

Add step to build flyway container #2593

merged 13 commits into from
Sep 19, 2024

Conversation

m-goggins
Copy link
Collaborator

PULL REQUEST

Summary

Make a flyway container available for release and deployment

Related Issue

Fixes #

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

bamader
bamader reviewed Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a Q around the change to the DB URL. Not sure if the connection was actually relying on the appropriate name being db as opposed to just the namespace localhost.

containers/tefca-viewer/tefca.env Outdated Show resolved Hide resolved
bamader
bamader approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol snuck the fix commit in there

bamader
bamader approved these changes Sep 19, 2024
View reviewed changes
.github/workflows/container-tefca-viewer.yaml Outdated Show resolved Hide resolved
@m-goggins m-goggins added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 1983b9f Sep 19, 2024
10 checks passed
@m-goggins m-goggins deleted the flyway-image branch September 19, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bamader bamader bamader approved these changes

@fzhao99 fzhao99 Awaiting requested review from fzhao99

@robertandremitchell robertandremitchell Awaiting requested review from robertandremitchell

@alismx alismx Awaiting requested review from alismx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-goggins @bamader