Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional chaining for facility contact address #2672

Merged
merged 5 commits into from
Oct 7, 2024

Conversation

angelathe
Copy link
Collaborator

@angelathe angelathe commented Oct 4, 2024

PULL REQUEST

Summary

Add optional chaining to Encounter Info Facility Contact Address info, so that the eCR Viewer doesn't crash when we load an eCR.

Example: http://localhost:3000/view-data?id=016accab-d6bf-11ec-81e1-8465ad080d41#eicr-custodian-details

Related Issue

N/A - Fixes bug that happened during live demo :(

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@angelathe angelathe self-assigned this Oct 4, 2024
@angelathe angelathe marked this pull request as ready for review October 4, 2024 18:59
Copy link
Collaborator

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! Just one tiny nit.

@angelathe angelathe added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 8953e77 Oct 7, 2024
11 checks passed
@angelathe angelathe deleted the angela/facility-address-missing branch October 7, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants