Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make golden sick patient for demo flow #2674

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

fzhao99
Copy link
Collaborator

@fzhao99 fzhao99 commented Oct 4, 2024

PULL REQUEST

Summary

Makes a very sick patient for use in the patient discovery page. Putting it up to make sure it looks semi-reasonable before progressing

Related Issue

Part one #2645. Once merged, will post the patient to OpenHAPI and handle the autopopulation in the final ticket to align the patient discovery page with our designs

Acceptance Criteria

Since we're removing the dropdowns from patient discovery to later stages, we'll need a golden patient that has all the relevant use case sicknesses to populate at once, which will allow us to get all the relevant use cases later on

Additional Information

Anything else the review team should know?

@fzhao99 fzhao99 marked this pull request as ready for review October 4, 2024 18:49
@fzhao99 fzhao99 changed the title first pass make golden sick patient for demo flow Oct 5, 2024
Copy link
Collaborator

@m-goggins m-goggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though it will be easier to see if we're missing anything once the data is loaded. Left a few comments but nothing that should be a blocker.

@@ -0,0 +1,10893 @@
// Patient ID: f288c654-6885-4f48-999c-48d776dc06af
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to delete these

"meta": {
"lastUpdated": "2024-10-04T15:52:02.656+00:00"
},
"type": "searchset",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might run into an issue loading into HAPI if you keep the type as searchset. If you do, I would try transaction instead.

"name": [
{
"family": "Unlucky",
"given": ["Hyper", "A."],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@fzhao99 fzhao99 enabled auto-merge October 7, 2024 20:44
@fzhao99 fzhao99 added this pull request to the merge queue Oct 7, 2024
@fzhao99 fzhao99 removed this pull request from the merge queue due to a manual request Oct 7, 2024
@fzhao99 fzhao99 added this pull request to the merge queue Oct 7, 2024
@fzhao99 fzhao99 removed this pull request from the merge queue due to a manual request Oct 7, 2024
Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for putting this together.

@fzhao99 fzhao99 added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 6277779 Oct 7, 2024
10 checks passed
@fzhao99 fzhao99 deleted the bob/2645-make-golden-patient branch October 7, 2024 20:59
@fzhao99 fzhao99 mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants