834 message parser meta data #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbristow
requested review from
emmastephenson,
gordonfarrell and
KennethSkylight
Codecov Report
@@ Coverage Diff @@
## main #853 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 45 45
Lines 2628 2628
=======================================
Hits 2533 2533
Misses 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
From a technical perspective, LGTM. But I'm still a little confused about the underlying need for this work, and I'm not sure the metadata we need to add is the FHIR metadata for a bundle - my interpretation is that it's more like the "constant" fields between conditions? But would like to check with Sarah and Ann on how we intend to use this.
emmastephenson
approved these changes
Oct 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Adds an option for metadata to
parse_messagethat returns additional metadata for each fieldSummary
What changes are being proposed?
Related Issue
Fixes #834
Additional Information
Anything else the review team should know?