Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DAL session management to support connection pooling #911

Merged
merged 43 commits into from
Nov 7, 2023

Conversation

DanPaseltiner
Copy link
Collaborator

@DanPaseltiner DanPaseltiner commented Nov 6, 2023

PULL REQUEST

Summary

This PR introduces changes to how the MPI client manages SQLAlchemy sessions and schema initialization in order to support connection pooling.

Related Issue

Fixes #

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link
Collaborator

@m-goggins m-goggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just deleted one final print statement

phdi/linkage/mpi.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #911 (c03e709) into main (c4b5712) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   96.38%   96.48%   +0.10%     
==========================================
  Files          48       48              
  Lines        2820     2820              
==========================================
+ Hits         2718     2721       +3     
+ Misses        102       99       -3     
Flag Coverage Δ
unit-tests 96.48% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
phdi/linkage/dal.py 100.00% <100.00%> (+2.91%) ⬆️
phdi/linkage/mpi.py 96.15% <100.00%> (+0.04%) ⬆️

@DanPaseltiner DanPaseltiner merged commit b501f1d into main Nov 7, 2023
20 checks passed
@DanPaseltiner DanPaseltiner deleted the fix-dal-session-managment branch November 7, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants